Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10464#discussion_r48534997
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala
---
@@ -52,7 +52,13 @@ class SocketReceiver[T: ClassTag](
storageLevel: StorageLevel
) extends Receiver[T](storageLevel) with Logging {
+ private var socket: Socket = null
+
def onStart() {
+ logInfo(s"Connecting to $host:$port")
+ socket = new Socket(host, port)
+ logInfo(s"Connecting to $host:$port")
--- End diff --
Log message is wrong -- it's connected now. You could omit this message
anyway. Don't you need to move handling of `ConnectException` here? and
finally, nit, but I think initializing the socket value to "_" is more
canonical in Scala? if you initialize at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
