Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10464#discussion_r48596197
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala
---
@@ -52,46 +52,60 @@ class SocketReceiver[T: ClassTag](
storageLevel: StorageLevel
) extends Receiver[T](storageLevel) with Logging {
+ private var socket: Socket = _
+
def onStart() {
- // Start the thread that receives data over a connection
- new Thread("Socket Receiver") {
- setDaemon(true)
- override def run() { receive() }
- }.start()
+
+ try {
+ logInfo(s"Connecting to $host:$port")
+ socket = new Socket(host, port)
+ logInfo(s"Connected to $host:$port")
+
+ // Start the thread that receives data over a connection
+ new Thread("Socket Receiver") {
+ setDaemon(true)
+ override def run() { receive() }
+ }.start()
+ } catch {
+ case e: ConnectException =>
--- End diff --
Good question. If it fails to connect, it seems like that should be a fatal
error and not attempt to restart. So I suppose you could not catch anything in
`onStart` as failures here are more fatal. Later, it makes sense to still catch
general exceptions (not `ConnectException`) and maybe try to restart
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
