Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10852#discussion_r50768962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -443,25 +444,32 @@ class Analyzer(
// When resolve `SortOrder`s in Sort based on child, don't report
errors as
// we still have chance to resolve it based on grandchild
case s @ Sort(ordering, global, child) if child.resolved &&
!s.resolved =>
- val newOrdering = resolveSortOrders(ordering, child, throws =
false)
+ val newOrdering = ordering.map(order =>
+ resolveExpression(order, child, throws =
false).asInstanceOf[SortOrder])
Sort(newOrdering, global, child)
// A special case for Generate, because the output of Generate
should not be resolved by
// ResolveReferences. Attributes in the output will be resolved by
ResolveGenerate.
case g @ Generate(generator, join, outer, qualifier, output, child)
if child.resolved && !generator.resolved =>
- val newG = generator transformUp {
- case u @ UnresolvedAttribute(nameParts) =>
- withPosition(u) { child.resolve(nameParts,
resolver).getOrElse(u) }
- case UnresolvedExtractValue(child, fieldExpr) =>
- ExtractValue(child, fieldExpr, resolver)
- }
+ val newG = resolveExpression(generator, child)
if (newG.fastEquals(generator)) {
g
} else {
Generate(newG.asInstanceOf[Generator], join, outer, qualifier,
output, child)
}
+ case o: ObjectOperator if
containsUnresolvedDeserializer(o.deserializers.map(_._1)) =>
--- End diff --
Add a comment about why this case is special.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
