Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10852#discussion_r50774569
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
    @@ -142,12 +143,14 @@ case class MapGroups(
      */
     case class CoGroup(
         func: (Any, Iterator[Any], Iterator[Any]) => TraversableOnce[Any],
    -    keyObject: Expression,
    -    leftObject: Expression,
    -    rightObject: Expression,
    +    keyDeserializer: Expression,
    +    leftDeserializer: Expression,
    +    rightDeserializer: Expression,
         serializer: Seq[NamedExpression],
         leftGroup: Seq[Attribute],
         rightGroup: Seq[Attribute],
    +    leftAttr: Seq[Attribute],
    +    rightAttr: Seq[Attribute],
    --- End diff --
    
    No they are different. Like `MapGroups`, the child.output also contains 
grouping attributes, which may cause problems if we have same name attribute in 
grouping attributes and data attributes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to