Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10852#discussion_r50774731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -44,18 +53,30 @@ trait ObjectOperator extends LogicalPlan {
def withObjectOutput: LogicalPlan = if
(output.head.dataType.isInstanceOf[ObjectType]) {
this
} else {
- withNewSerializer(outputObject)
+ withNewSerializer(outputObject :: Nil)
}
/** Returns a copy of this operator with a different serializer. */
- def withNewSerializer(newSerializer: NamedExpression): LogicalPlan =
makeCopy {
+ def withNewSerializer(newSerializer: Seq[NamedExpression]): LogicalPlan
= makeCopy {
--- End diff --
according to the definition of serializer: `def serializer:
Seq[NamedExpression]`, a seq of named expressions work together as a serialize,
so `withNewSerializer` seems more accuracy here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
