Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10808#discussion_r51495310
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -340,4 +347,24 @@ private[mesos] trait MesosSchedulerUtils extends
Logging {
sc.conf.getTimeAsSeconds("spark.mesos.rejectOfferDurationForUnmetConstraints",
"120s")
}
+ protected def getExecutorRelatedPort(sc: SparkContext, configProperty:
String): Int = {
+ // either: spark.blockManager.port or spark.executor.port
--- End diff --
I don't think this is a great abstraction; you're passing the whole `sc` in
here but only to get its conf. I think the caller can just get the port
themselves easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
