Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10808#issuecomment-178248032
@dragos @skonto I haven't gone through the entire patch in great detail yet
but I have 3 high level concerns:
1. This patch lacks comments / proper abstractions and makes the code
difficult to follow
2. Currently the only consumer of port restriction if Mesos fine-grained
mode, which isn't even the default. I would leave as much logic outside of
core's `Utils` as possible. If we do decide to support it for other modes then
we should file a separate issue so we can review that change in isolation.
3. Fine-grained mode will be deprecated, if not removed, soon. I'm not sure
if this change is super worth it given its complexity. If it's a small,
isolated change then maybe it makes sense to add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
