Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10808#discussion_r51495503
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -340,4 +347,24 @@ private[mesos] trait MesosSchedulerUtils extends
Logging {
sc.conf.getTimeAsSeconds("spark.mesos.rejectOfferDurationForUnmetConstraints",
"120s")
}
+ protected def getExecutorRelatedPort(sc: SparkContext, configProperty:
String): Int = {
+ // either: spark.blockManager.port or spark.executor.port
+ sc.conf.getInt(s"$configProperty", 0)
+ }
+
+ protected def checkPorts(sc: SparkContext, ports: List[(Long, Long)]):
Boolean = {
--- End diff --
you need to document what these tuples mean. This method needs a java doc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
