Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11746#discussion_r56269865
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
@@ -48,13 +48,16 @@ private[deploy] class DriverRunner(
val securityManager: SecurityManager)
extends Logging {
- @volatile private var process: Option[Process] = None
- @volatile private var killed = false
+ private var workerThread: Thread = null
+ private var process: Process = null
--- End diff --
I opted not to use an AtomicReference on the `process` variable, although
it is shared with the ShutdownHookManager, I think if the hook is invoked then
it's not an issue at that point because it means the JVM is exiting right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
