Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1313#issuecomment-50288953
BTW one other thing I should add is that it would be good to update the
comments of these methods when you make a PR. For example, if you go with the
way I suggested above, in resourceOffer you would say that it's either called
with a "real" locality level, in which case it does delay scheduling, or with
the special level NO_PREFS, in which case it checks for no-prefs tasks without
adjusting its last locality value. And in the code in TaskSchedulerImpl,
explain the order it makes requests in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
