Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r15477801
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -158,18 +180,40 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
* @param renderUI Whether to create the SparkUI for the application.
* @return A 2-tuple `(app info, ui)`. `ui` will be null if `renderUI`
is false.
*/
- private def loadAppInfo(logDir: FileStatus, renderUI: Boolean) = {
- val elogInfo = EventLoggingListener.parseLoggingInfo(logDir.getPath(),
fs)
- val path = logDir.getPath
- val appId = path.getName
- val replayBus = new ReplayListenerBus(elogInfo.logPaths, fs,
elogInfo.compressionCodec)
+ private def loadAppInfo(log: FileStatus, renderUI: Boolean):
(ApplicationHistoryInfo, SparkUI) = {
+ val elogInfo = if (log.isFile()) {
+ EventLoggingListener.parseLoggingInfo(log.getPath())
+ } else {
+ loadOldLoggingInfo(log.getPath())
+ }
+
+ if (elogInfo == null) {
+ return (null, null)
+ }
+
+ val (appName, logFile, lastUpdated) = if (log.isFile()) {
+ // Due to SPARK-2169, we need to provide the name of the
application to be shown in
--- End diff --
minor: This line sounds like SPARK-2169 is a bug when it's not. Maybe
instead say "As of SPARK-2169" or something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
