Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-50376594
@vanzin It seems that with the changes in this PR the new filename will
look something like
```
app-spark-shell-201407281106.1.0.0.LZFCompression.inprogress
```
This is pretty hard to read and the file name regex becomes somewhat
complicated. If the app name is very long and we decide to add more fields in
the future, we may hit a different limitation of the file system, i.e. the
length of the file name. I think what we want to do instead is have two files,
(1) the event log and (2) the metadata, instead of trying to encode all the
information in the file names (as we have done even before your PR).
The other thing is that I notice you pass a lot of `null`s around. It would
be good if you could avoid these for initialization of variables or returning
from methods, either through Options or other more concise ways of rewriting
the logic.
Also, if you could up-merge this once you have a chance that would be
great. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
