Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r15477871
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -126,14 +145,17 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
// For any application that either (i) is not listed or (ii) has
changed since the last time
// the listing was created (defined by the log dir's modification
time), load the app's info.
// Otherwise just reuse what's already in memory.
- val newApps = new
mutable.ArrayBuffer[ApplicationHistoryInfo](logInfos.size)
- for (dir <- logInfos) {
- val curr = currentApps.getOrElse(dir.getPath().getName(), null)
- if (curr == null || curr.lastUpdated < getModificationTime(dir)) {
+ val newApps = new mutable.ListBuffer[ApplicationHistoryInfo]
+ for (log <- logInfos) {
+ val curr = currentApps.getOrElse(log.getPath().getName(), null)
+ if (curr == null || curr.lastUpdated < log.getModificationTime()) {
try {
- newApps += loadAppInfo(dir, false)._1
+ val info = loadAppInfo(log, false)._1
+ if (info != null) {
+ newApps += info
+ }
} catch {
- case e: Exception => logError(s"Failed to load app info from
directory $dir.")
+ case e: Exception => logError(s"Failed to load app info from
directory $log.")
--- End diff --
is it still a directory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
