Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11876#discussion_r56990359
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -111,6 +110,14 @@ class SparkHadoopUtil extends Logging {
       }
     
       /**
    +    * Return an appropriate (subclass) of Configuration. Creating config 
can initializes some Hadoop
    +    * subsystems.
    +    */
    +  def newConfiguration(conf: SparkConf): Configuration = {
    --- End diff --
    
    I'm curious where this is used after your change... generally it's not a 
great idea to make a new `Configuration` since there is probably one with 
appropriate configuration available that should be used with your new method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to