Github user sitalkedia commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11876#discussion_r57014873
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -111,6 +110,14 @@ class SparkHadoopUtil extends Logging {
       }
     
       /**
    +    * Return an appropriate (subclass) of Configuration. Creating config 
can initializes some Hadoop
    +    * subsystems.
    +    */
    +  def newConfiguration(conf: SparkConf): Configuration = {
    --- End diff --
    
    This is being used from a bunch of other places in the code base. I agree 
with you that its not a good idea to create a new Configuration instead of 
reusing it and we should change that behavior.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to