Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11876#discussion_r57072981
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -74,13 +74,12 @@ class SparkHadoopUtil extends Logging {
         }
       }
     
    -  /**
    -   * Return an appropriate (subclass) of Configuration. Creating config 
can initializes some Hadoop
    -   * subsystems.
    -   */
    -  def newConfiguration(conf: SparkConf): Configuration = {
    -    val hadoopConf = new Configuration()
     
    +  /**
    +    * Appends S3-specific configurations and spark.hadoop.* configurations 
to a Hadoop
    --- End diff --
    
    Maybe also mention the buffer keys that are also added that don't fit into 
either of those.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to