Github user oliverpierson commented on the pull request:
https://github.com/apache/spark/pull/11553#issuecomment-201321707
@mengxr Thanks for the review. Concerning `getRelativeError`, we had
decided to not call `$(relativeError)` directly because we wanted the default
value to vary with the `numBuckets` (see @thunterdb comments above). I agree
that it is a bit ugly and also creates issues for future developers calling
`$(relative)` instead of `getRelativeError`. I'm totally open to suggestions
for changing this. Perhaps `approxQuantile` could default to a particular
value for `relativeError` base on `probabilites.length`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
