Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11796#discussion_r58098143
  
    --- Diff: assembly/pom.xml ---
    @@ -69,6 +68,17 @@
           <artifactId>spark-repl_${scala.binary.version}</artifactId>
           <version>${project.version}</version>
         </dependency>
    +
    +    <!--
    +      Because we don't shade dependencies anymore, we need to restore 
Guava to compile scope so
    +      that the libraries Spark depend on have it available. We'll package 
the version that Spark
    +      uses (14.0.1) which is not the same as Hadoop dependencies, but 
works.
    +    -->
    +    <dependency>
    --- End diff --
    
    When and if this turns out to be a problem for user applications, we can 
consider a different dependency shading strategy in a followup patch. 
Therefore, I'm fine with this change for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to