Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11796#discussion_r58101475
  
    --- Diff: project/SparkBuild.scala ---
    @@ -263,8 +264,14 @@ object SparkBuild extends PomBuild {
       /* Unsafe settings */
       enable(Unsafe.settings)(unsafe)
     
    -  /* Set up tasks to copy dependencies during packaging. */
    -  copyJarsProjects.foreach(enable(CopyDependencies.settings))
    +  /*
    +   * Set up tasks to copy dependencies during packaging. This step can be 
disabled in the command
    +   * line, so that dev/mima can run without trying to copy these files 
again and potentially
    +   * causing issues.
    +   */
    +  if (!"false".equals(System.getProperty("copyDependencies"))) {
    --- End diff --
    
    We currently only run MiMa with SBT so I don't think that the MiMa SBT 
invocation overwriting some output produced by Maven is a concern at this 
point. However, I appreciate the flag and propose to leave it in place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to