Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11796#discussion_r58101803
--- Diff: project/SparkBuild.scala ---
@@ -748,6 +739,13 @@ object Java8TestSettings {
object TestSettings {
import BuildCommons._
+ private val scalaBinaryVersion =
+ if (System.getProperty("scala-2.10") == "true") {
--- End diff --
Is it possible to read this from the POM rather than relying on a system
property to be set? I'm worried that the approach used here will not work if we
have to support three Scala versions (2.10, 2.11, and 2.12).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
