Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11805#discussion_r58127781
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
---
@@ -86,7 +83,7 @@ class StorageLevel private(
false
}
- def isValid: Boolean = (useMemory || useDisk || useOffHeap) &&
(replication > 0)
+ def isValid: Boolean = (useMemory || useDisk) && (replication > 0)
--- End diff --
I always thought that `isValid` was somewhat confusingly-named. From its
current usage, `isValid` means "if we interpret this StorageLevel as a block's
effective StorageLevel (i.e. a descriptor of where it's actually stored) then
the block exists in at least one block store." Under that interpretation, I
believe that this definition of `isValid` is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
