Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11805#discussion_r58132067
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
---
@@ -60,10 +60,7 @@ class StorageLevel private(
assert(replication < 40, "Replication restricted to be less than 40 for
calculating hash codes")
if (useOffHeap) {
- require(!useDisk, "Off-heap storage level does not support using disk")
- require(!useMemory, "Off-heap storage level does not support using
heap memory")
require(!deserialized, "Off-heap storage level does not support
deserialized storage")
--- End diff --
as discussed offline, we should also require that `offHeap` implies
`useMemory`.
(Additionally `useDisk` should imply `!deserialized`, but we can do that
later if you prefer)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
