Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11805#discussion_r58128136
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -86,7 +91,8 @@ private[spark] class MemoryStore(
// A mapping from taskAttemptId to amount of memory used for unrolling a
block (in bytes)
// All accesses of this map are assumed to have manually synchronized on
`memoryManager`
- private val unrollMemoryMap = mutable.HashMap[Long, Long]()
+ private val onHeapUnrollMemoryMap = mutable.HashMap[Long, Long]()
+ private val offHeapUnrollMemoryMap = mutable.HashMap[Long, Long]()
--- End diff --
can you add a comment here to say the off heap one is only used for bytes?
(Is that true)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
