Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15670431
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -121,6 +121,10 @@ private[spark] class Executor(
}
}
+ def stop() {
--- End diff --
Could you add the `Unit` return type here and other places as well? I know
much of the existing code doesn't do it but it would be good to add this for
new code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
