Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12157#discussion_r60093535
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/FixedHashObject.scala ---
@@ -22,4 +22,8 @@ package org.apache.spark.util.collection
*/
case class FixedHashObject(v: Int, h: Int) extends Serializable {
override def hashCode(): Int = h
+ override def equals(other: Any): Boolean = other match {
--- End diff --
Although this very technically changes semantics, given the clear and
specific purpose of this class, I don't think it hurts to define reasonable
equality semantics instead of leaving it to reference equality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
