Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12157#issuecomment-211473558
I think it's a good change because it lets us enforce the fairly important
practice of defining equals/hashCode together. This actually forces it to be
explicit in all cases where either of the two is defined, which is IMHO a good
thing, as it's something that's easy to get subtly wrong.
The new equals() methods don't change behavior (with one exception that
seems fine); existing hashCode() methods have the same behavior; new hashCode()
methods look consistent with equals(). And tests pass. That LGTM.
My remaining comments are just a nit about implementation of the hash
codes, and multiplying by a prime number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
