Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12157#discussion_r60093736
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -112,12 +114,15 @@ final class CategoricalSplit private[ml] (
}
}
- override def equals(o: Any): Boolean = {
- o match {
- case other: CategoricalSplit => featureIndex == other.featureIndex &&
- isLeft == other.isLeft && categories == other.categories
- case _ => false
- }
+ override def hashCode(): Int = {
+ val state = Seq(featureIndex, isLeft, categories)
+ state.map(Objects.hashCode).foldLeft(0)((a, b) => 36 * a + b)
--- End diff --
Nit: isn't something like 31 used as the multiplier because it's prime?
while any prime is probably OK maybe 36 is a tiny bit less optimal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
