Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/1076#issuecomment-50820863
  
    Hi @rahulsinghaliitd, looks like we only ever `report()` when we also want 
to stop the metrics system. I wonder if it makes sense for each of the sinks to 
just do its reporting inside of `stop()`? That way we don't need to add a new 
method to each of them (report) that is only used when another method (stop) is 
called. I am no expert on the metrics system, but is there a reason to separate 
the two?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to