Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15675679
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -357,6 +357,7 @@ private[spark] class Worker(
}
override def postStop() {
+ metricsSystem.report()
--- End diff --
I thought it is best to keep it here since the metricsystem may be
dependent on other components. This way the we can separate out the two pieces
of code and avoid any dependency issues. So this extra call just
becomes/behaves like another scheduled call from the timer of the reporter, had
the spark component not been stopped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
