Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15682191
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -350,4 +353,47 @@ private[spark] class Executor(
           }
         }
       }
    +
    +  def stop() {
    +    isStopped = true
    +    threadPool.shutdown()
    +  }
    +
    +  def startDriverHeartbeater() {
    +    val interval = conf.getInt("spark.executor.heartbeatInterval", 2000)
    --- End diff --
    
    should we turn this down to something like 10 seconds by default? Unlike in 
Hadoop, we don't rely on this in order for tasks to start or finish. It might 
be good to stay conservative here to make sure performance is not an issue. The 
main value as I see it for this feature in general is to deal with long running 
tasks anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to