Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15682364
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala ---
    @@ -56,7 +56,7 @@ private[jobs] object UIData {
       }
     
       case class TaskUIData(
    -      taskInfo: TaskInfo,
    -      taskMetrics: Option[TaskMetrics] = None,
    -      errorMessage: Option[String] = None)
    +      var taskInfo: TaskInfo,
    +      var taskMetrics: Option[TaskMetrics] = None,
    +      var errorMessage: Option[String] = None)
    --- End diff --
    
    In general we strongly prefer immutable data structures because it's much 
easier to reason about their state. On this one I'd actually propose keeping it 
immutable and we can see if we need to adjust that in the future. I'd actually 
recommend decreasing the heartbeat interval to something like 10 seconds (or 
maybe less frequent) anyways. To avoid this and other problems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to