Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r60726431
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -656,7 +656,8 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
itemFactors.setName(s"itemFactors-$iter").persist(intermediateRDDStorageLevel)
// TODO: Generalize PeriodicGraphCheckpointer and use it here.
if (shouldCheckpoint(iter)) {
- itemFactors.checkpoint() // itemFactors gets materialized in
computeFactors.
+ // itemFactors gets materialized in computeFactors & here.
+ ALS.checkpointAndCleanParents(itemFactors)
--- End diff --
@mengxr just want to get your opinion on this - I think an extra `count` in
the implicit case is not too bad.
Having said that, I took another look and it would only be a few extra
lines to capture the shuffle deps in L660 & L676 (similar to how
`previousCheckpointFile` works), and clean them just before
`deletePreviousCheckpointFile()` is called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
