Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r60913012
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -656,13 +656,15 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
previousItemFactors.unpersist()
itemFactors.setName(s"itemFactors-$iter").persist(intermediateRDDStorageLevel)
// TODO: Generalize PeriodicGraphCheckpointer and use it here.
+ val deps = itemFactors.dependencies
--- End diff --
really minor, but let's move this a line down under `if
(shouldCheckpoint(iter)) { `, just to match the explicit case below
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]