Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r60926339
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -673,9 +675,11 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
itemFactors = computeFactors(userFactors, userOutBlocks,
itemInBlocks, rank, regParam,
userLocalIndexEncoder, solver = solver)
if (shouldCheckpoint(iter)) {
+ val deps = itemFactors.dependencies
itemFactors.checkpoint()
itemFactors.count() // checkpoint item factors and cut lineage
deletePreviousCheckpointFile()
+ ALS.cleanDependencies(sc, deps)
--- End diff --
minor but let's move this up one line to be consistent with the implicit
case above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
