Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1481#discussion_r15717899
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -567,10 +567,12 @@ private[spark] class BlockManager(
blockId: BlockId,
file: File,
serializer: Serializer,
- bufferSize: Int): BlockObjectWriter = {
+ bufferSize: Int,
+ writeMetrics: Option[ShuffleWriteMetrics] = None): BlockObjectWriter
= {
--- End diff --
There is a bit of a mismatch in this function signature, the doc says "This
is currently used for writing shuffle files out.", but the shuffle write
metrics are optional. I think the doc is just stale, because we now use this in
other cases where we might not be writing out shuffle data, so can you just
remove that line from the doc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
