Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1481#discussion_r15718740
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
    @@ -176,7 +183,9 @@ private[spark] class DiskBlockObjectWriter(
         if (!initialized) {
           open()
         }
    +    val prevPos = channel.position()
    --- End diff --
    
    this seems like it will have potentially high overhead... this is called 
when writing each individual record


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to