Github user sryza commented on the pull request:

    https://github.com/apache/spark/pull/1481#issuecomment-50977756
  
    I hadn't noticed this before, but DiskObjectWriter is used for tracking 
bytes spilled by ExternalSorter and ExternalAppendOnlyMap in addition to 
shuffle bytes written.  So in some cases it needs to bill to 
TaskMetrics.diskBytesSpilled as well.  Any thoughts on the best way to handle 
this?  The options as I see it are:
    
    * Pass in TaskMetrics and some flag about which metric to update to 
DiskObjectWriter
    * Pass in a callback that DiskObjectWriter can notify when it writes bytes
    * Pass in a MutableLong


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to