Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1481#discussion_r15737617
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleWriter.scala ---
@@ -39,10 +39,13 @@ private[spark] class HashShuffleWriter[K, V](
// we don't try deleting files, etc twice.
private var stopping = false
+ metrics.shuffleWriteMetrics = Some(new ShuffleWriteMetrics())
--- End diff --
minor: but in this file and `SortShuffleWriter` it might be slightly nicer
to keep a pointer to the writeMetrics and then use that, rather than calling
`.get` on the option to get it back. Just a bit more robust to re-factoring if
the code gets changed around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
