Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1481#issuecomment-51008685
I tool a pass. I like the new approach, with this approach you actually net
remove code from Spark, which is great. Left comments inline. This needs some
unit tests as well. It shouldn't be too hard because you can create a
`BlockObjectWriter` pretty easily (it is fairly self-contained thing). One
thing that might be helpful for unit tests is adding a private `flush` method
to `BlockObjectWriter` - since otherwise writes will get buffered inside of the
inner streams and you might not ever see them in the resulting file if you are
writing small amounts of data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
