Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1481#discussion_r15737300
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -89,6 +90,8 @@ class ExternalAppendOnlyMap[K, V, C](
// How much of the shared memory pool this collection has claimed
private var myMemoryThreshold = 0L
+ private val writeMetrics = new ShuffleWriteMetrics
--- End diff --
It's a bit strange that the same metrics object is re-used here. Can you
just create a new ShuffleWriteMetrics every time you create a writer? That is
more the model I was thinking of.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
