Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1758#discussion_r15768094
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -41,16 +42,26 @@ import org.apache.spark.util.{SystemClock, Utils}
private[spark] class ConnectionManager(port: Int, conf: SparkConf,
securityManager: SecurityManager) extends Logging {
+ /**
+ * Used by sendMessageReliably to track messages being sent.
+ * @param message the message that was sent
+ * @param connectionManagerId the connection manager that sent this
message
+ * @param completionHandler callback that's invoked when the send has
completed or failed
+ */
class MessageStatus(
val message: Message,
val connectionManagerId: ConnectionManagerId,
completionHandler: MessageStatus => Unit) {
+ /** This is non-None if message has been ack'd */
var ackMessage: Option[Message] = None
- var attempted = false
--- End diff --
You'll notice that I removed a bunch of fields here. `attempted` was never
read anywhere, and `acked` implied `ackMessage != None`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
