Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1758#discussion_r15768152
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -815,11 +819,28 @@ private[spark] class ConnectionManager(port: Int,
conf: SparkConf,
selector.wakeup()
}
+ /**
+ * Send a message and block until an acknowldgment is received or an
error occurs.
+ * @param connectionManagerId the message's destination
+ * @param message the message being sent
+ * @return a Future that either returns the acknowledgment message or
captures an exception.
+ */
def sendMessageReliably(connectionManagerId: ConnectionManagerId,
message: Message)
- : Future[Option[Message]] = {
- val promise = Promise[Option[Message]]
- val status = new MessageStatus(
- message, connectionManagerId, s => promise.success(s.ackMessage))
+ : Future[Message] = {
--- End diff --
Since we now signal failures via Futures, I changed this into
`Future[Message]` instead of `Future[Some[Message]]`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
