Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1758#issuecomment-51115693
It looks like this caused a test failure! After this patch
`sendMessagReliablySync` throws IOException if the send fails, and the code in
the "security mismatch password" test didn't have any error handling for this
method, leading to an error:
```
sendMessageReliably failed without being ACK'd
java.io.IOException: sendMessageReliably failed without being ACK'd
at
org.apache.spark.network.ConnectionManager$$anonfun$13.apply(ConnectionManager.scala:834)
at
org.apache.spark.network.ConnectionManager$$anonfun$13.apply(ConnectionManager.scala:831)
at
org.apache.spark.network.ConnectionManager$MessageStatus.markDone(ConnectionManager.scala:62)
at
org.apache.spark.network.ConnectionManager$$anonfun$removeConnection$3.apply(ConnectionManager.scala:448)
at
org.apache.spark.network.ConnectionManager$$anonfun$removeConnection$3.apply(ConnectionManager.scala:446)
at scala.collection.immutable.List.foreach(List.scala:318)
at
org.apache.spark.network.ConnectionManager.removeConnection(ConnectionManager.scala:446)
at
org.apache.spark.network.ConnectionManager$$anonfun$addListeners$3.apply(ConnectionManager.scala:425)
at
org.apache.spark.network.ConnectionManager$$anonfun$addListeners$3.apply(ConnectionManager.scala:425)
at
org.apache.spark.network.Connection.callOnCloseCallback(Connection.scala:156)
at org.apache.spark.network.Connection.close(Connection.scala:128)
at org.apache.spark.network.SendingConnection.read(Connection.scala:392)
at
org.apache.spark.network.ConnectionManager$$anon$6.run(ConnectionManager.scala:190)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
```
I'll walk through the code to try to find any other call sites that lack
error-handling code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
