Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10061#discussion_r63812300
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -96,6 +100,7 @@ private[spark] object JsonProtocol {
executorMetricsUpdateToJson(metricsUpdate)
case blockUpdated: SparkListenerBlockUpdated =>
throw new MatchError(blockUpdated) // TODO(ekl) implement this
+ case _ => parse(mapper.writeValueAsString(event))
--- End diff --
As I've said in similar conversations in other contexts, I'm strongly
opposed to what you're suggesting. In fact I'm an advocate for exactly the
opposite, and that's why I filed SPARK-12141.
BTW just removing that line would break the feature this patch is
implementing, unless you write a whole lot of code to manually serialize all
the SQL-related events.
Events are a public API, and they should be carefully crafted, since
changing them affects user applications (including event logs). If there is
unnecessary information in the event, then it's a bug in the event definition,
not here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
