Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10061#discussion_r63921800
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -96,6 +100,7 @@ private[spark] object JsonProtocol {
executorMetricsUpdateToJson(metricsUpdate)
case blockUpdated: SparkListenerBlockUpdated =>
throw new MatchError(blockUpdated) // TODO(ekl) implement this
+ case _ => parse(mapper.writeValueAsString(event))
--- End diff --
Could you guys please comment on the bug I opened or the mailing list?
Commenting on a long closed github PR is not really the best forum.
I'd really like to understand why you think automatic serialization is a
bad idea, since we use it in so many places. I think exactly the opposite -
manual serialization is unmaintainable, error-prone, and a waste of developer
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
