Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10061#discussion_r63914121
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -96,6 +100,7 @@ private[spark] object JsonProtocol {
             executorMetricsUpdateToJson(metricsUpdate)
           case blockUpdated: SparkListenerBlockUpdated =>
             throw new MatchError(blockUpdated)  // TODO(ekl) implement this
    +      case _ => parse(mapper.writeValueAsString(event))
    --- End diff --
    
    BTW this is really not the right forum to discuss this. If you want to 
discuss big changes like you're proposing, please discuss on the bug I opened 
(referenced above) or start a thread on the mailing list.
    
    Your suggestion of removing that line will just break the feature and, to 
restore it, would require an insane amount of code motion and new code to be 
written. To start with, the SQL events are not even available in "core", so you 
can't reference the classes here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to