Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1813#discussion_r15907274
  
    --- Diff: pom.xml ---
    @@ -249,6 +249,7 @@
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
             <version>14.0.1</version>
    +        <scope>provided</scope>
    --- End diff --
    
    I'll probably learn something here, but why is it necessary to mark it 
provided and then compile-scope again in the assembly? what does it matter if 
it's compile scope everywhere? I realize Hive on Spark may need it to be 
provided but it can change the nature of this dependency down-stream if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to