Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1813#discussion_r15909040
--- Diff: pom.xml ---
@@ -249,6 +249,7 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>14.0.1</version>
+ <scope>provided</scope>
--- End diff --
Yes it's what "provided" means, but why do you assume the app provides
Guava itself, but none of the others? I see no reason to think of Guava
specially and not Commons Math or log4j or whatever. What does it solve to
treat this exceptionally? It means extra declarations in Spark, and does not
affect your ability to shade the dependency in the assembly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
