Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1813#discussion_r15907528
--- Diff: pom.xml ---
@@ -249,6 +249,7 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>14.0.1</version>
+ <scope>provided</scope>
--- End diff --
If you leave it as compile, it will pollute the compilation classpath of
people using Spark in their projects (Guava will be pulled as a compile-scope
dependency too).
http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
Adding it as compile-scope in the assembly project is then needed because
maven-shade-plugin will only include those in the final jar (pretty sure there
are setting to include other scopes, but didn't want to play with those).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
