Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65773746
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -107,4 +106,17 @@ public void close() throws IOException {
}
}
+ private void close(Exception exp) throws IOException {
+ if (!closed) {
+ synchronized (this) {
+ if (!closed) {
+ handle(new SetState(State.FINISHED_UNKNOWN));
--- End diff --
Hmm, this looks out of place. I think a better place for this is the
`ServerConnection` class (in `LauncherServer.java`). That's the class that
understands this message. Then your patch is also much simpler since you don't
need this second close method, it turns into a single line in
`ServerConnection.close` (and maybe a log message).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
